WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#27169 closed enhancement (fixed)

Add Mixcloud to the internal oembed whitelist

Reported by: mattrawson Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.8.1
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

I would like to add mixcloud.com to the internal oembed whitelist.

wp-includes/class-oembed.php
Line 60

'#https?://(www\.)?mixcloud\.com)/.*#i' => array( 'http://www.mixcloud.com/oembed'

Attachments (2)

27169.patch (771 bytes) - added by Jayjdk 6 years ago.
27169.diff (771 bytes) - added by wonderboymusic 6 years ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
7 years ago

  • Description modified (diff)
  • Type changed from feature request to enhancement

#3 @matclayton
7 years ago

Hopefully these brief answers should help inform your decision and save you having to hunt around for answers. Let me know if you have any more questions, and myself or Matt should be able to help.

The reason for the patch now, is we are seeing increasing number of requests for this from users and we about to announce support for wordpress.com (http://en.support.wordpress.com/shortcodes/mixcloud-audio-player/). It would also be nice to have support in .org at the same time to save any user confusion.

  • Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”

No idea with this one :)

  • If similar services are already supported, how does this service compare in terms of size, features, and backing?

Soundcloud is the obvious similar service already supported, they are the larger player, however mixcloud currently has >10M monthly active users.

  • Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?

www.facebook.com/mixcloud 500,000 likes
www.twitter.com/mixcloud 200,000 followers (verified)

  • Is its oEmbed endpoint clearly established and properly documented? Sometimes, they are just a developer’s pet project that may not be supported.)

This is the same endpoint as used by wordpress.com (http://en.support.wordpress.com/shortcodes/mixcloud-audio-player/) and multiple other services we will be announcing soon. The oEmbed point has been actively support for over 2 years, and we will continue to support it.

Documentation is brief but available on http://www.mixcloud.com/developers/#embedding

  • Does the service make an effort to build relationships with developers, such as through robust APIs?

We have a fully supported api available on http://api.mixcloud.com/

  • How old is the service?

Went live in sept 2009

  • Does it have a well-established Wikipedia article? (Seriously.)

http://en.wikipedia.org/wiki/Mixcloud

  • Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?

The endpoint is supported by embed.ly http://embed.ly/embed/features/provider/mixcloud

We tend to push users towards using discovery and articles such as http://www.iwebcontrol.co.uk/2013/01/add-mixcloud-oembed-support-to-wordpress/

  • Is the provider frequently proposed?

We're seeing significant (100's) of requests in our support channels for this feature, however I'm not sure of the number of firm proposals you will have recieved

#4 in reply to: ↑ 2 @matclayton
6 years ago

Replying to SergeyBiryukov:

For reference: http://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers

Following up on this, is there any more information we'd need to supply to get this reviewed?

#5 @johnbillion
6 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.0

Thanks for the info Matt. Mixcloud and its oEmbed implementation both look solid so I'm moving this to 4.0 for consideration.

@Jayjdk
6 years ago

#6 @Jayjdk
6 years ago

  • Keywords has-patch added; needs-patch removed

The patch has a slightly changed regex (removed the parenthesis after .com)

@wonderboymusic
6 years ago

#7 @wonderboymusic
6 years ago

Patch refreshed after the oEmbed churn today.

I want to include this, but the endpoint is not working for http:// URLs, only works for https://.

It works here: http://www.mixcloud.com/oembed/?url=http://www.mixcloud.com/8_8s/love2dance/

...but not in our code. Will investigate.

#8 @Jayjdk
6 years ago

Both http:// and https:// URLs work for me on the latest trunk.

#9 @wonderboymusic
6 years ago

Mixcloud is an extremely popular service, especially with DJs. http:// is working for me now.

#10 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 28578:

Add oEmbed support for Mixcloud.

Props Jayjdk.
Fixes #27169.

Note: See TracTickets for help on using tickets.