Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #27177, comment 12


Ignore:
Timestamp:
05/01/2015 10:49:43 PM (11 years ago)
Author:
greenshady
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27177, comment 12

    initial v1  
    11One thing we need to watch out for is when a child theme developer overwrites the default theme mods of the parent theme.  For example, child themes can hook into `theme_mod_$mod`, check if the user has set anything yet, and return a new default mod if not.
    22
    3 If core begins overwriting mods on theme switch.  I know there are several child themes of my parent themes that wouldn't have their correct default theme mods if that were the case (mostly color options).  Users will think something is wrong because the child theme they activated will look nothing like it supposed to.  It'd just look like the parent theme.
     3If core begins overwriting mods on theme switch, it'll break things.  I know there are several child themes of my parent themes that wouldn't have their correct default theme mods if that were the case (mostly color options).  Users will think something is wrong because the child theme they activated will look nothing like it supposed to.  It'd just look like the parent theme.
    44
    55What theme authors really need to be doing is using the options storage method that best suits their needs.  Theme mods are specific to the `get_stylesheet()`.  If a theme author wants to store everything based on the parent theme, there are options to do so.