WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27182 closed enhancement (fixed)

Upgrade Backbone to 1.1.2

Reported by: gcorne Owned by:
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch commit
Focuses: javascript Cc:
PR Number:

Description

Backbone 1.1.1 and 1.1.2 have both been released. We should upgrade.

Changelog for 1.1.2:

  • Backbone no longer tries to require jQuery in Node/CommonJS environments, for better compatibility with folks using Browserify. If you'd like to have Backbone use jQuery from Node, assign it like so: Backbone.$ = require('jquery');
  • Bugfix for route parameters with newlines in them.

Change log for 1.1.1:

  • Backbone now registers itself for AMD (Require.js), Bower and Component, as well as being a CommonJS module and a regular (Java)Script. Whew.
  • Added an execute hook to the Router, which allows you to hook in and custom-parse route arguments, like query strings, for example.
  • Performance fine-tuning for Backbone Events.
  • Better matching for Unicode in routes, in old browsers.

In particular, the addition of an execute hook may help us with #26543

Attachments (2)

27182-01.patch (36.0 KB) - added by gcorne 6 years ago.
27182-02.patch (55.6 KB) - added by gcorne 6 years ago.

Download all attachments as: .zip

Change History (6)

@gcorne
6 years ago

#1 @gcorne
6 years ago

  • Keywords has-patch commit added

27182-01.patch takes care of the upgrade.

This ticket was mentioned in IRC in #wordpress-dev by ocean90. View the logs.


6 years ago

@gcorne
6 years ago

#3 @gcorne
6 years ago

27182-02.patch adds backbone.min.js back, which was accidentally left out.

#4 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [27233].

I have removed sourceMappingURL from the minified version, see #24994 for jQuery.

Note: See TracTickets for help on using tickets.