On a gallery update default shortcode attributes are added

[ocean90]

Steps to reproduce:

• Create a post with a gallery.
• Post content should look like [gallery ids="4197,5203"]
• Open the Edit Gallery modal by clicking on the gallery placeholder
• Press the "Update gallery" button
• Post content is now [gallery order="ASC" itemtag="dl" icontag="dt" captiontag="dd" columns="3" link="post" size="thumbnail" ids="4197,5203" orderby="menu_order ID"]

[bravokeyl]

I can't reproduce this..

[ocean90]

bravokeyl, which version have you tested?

[bravokeyl]

oh my bad .. i checked that on stable version..

On trunk: It's showing attributes as you stated

[JohnConners]

Explicitly using wp.media.gallery.defaults to remove default gallery attributes

[JohnConners]

So the bug is that at the point of attempting to remove any default gallery shortcode attributes, 'this.defaults' is undefined, so the defaults remain. I couldn't figure out if there's a mechanism whereby those defaults should have been populated by that line of code so my patch just explicitly passes them in. Please change accordingly!

[ocean90]

This needs to be more general.

Related: [27213], #27183.

[wonderboymusic]

Fixed in [27238].