Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27215 closed defect (bug) (fixed)

Role order is inconsistent between multisite and single site user forms

Reported by: jeremyfelt Owned by: SergeyBiryukov
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.7
Component: Users Keywords: has-patch
Focuses: multisite Cc:


In [25695], the role order of wp_dropdown_roles() was reversed. Because site-users.php does not yet use wp_dropdown_roles(), this introduced an inconsistency between the two forms.

Looking at the code in site-users.php, there doesn't appear to be any reason to not use wp_dropdown_roles().

Attached patch makes the change.

Attachments (1)

27215.diff (1.5 KB) - added by jeremyfelt 6 years ago.

Download all attachments as: .zip

Change History (3)

6 years ago

#1 @DrewAPicture
6 years ago

Nice. 27215.diff seems to be in order. +1

#2 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 27310:

Use wp_dropdown_roles() in wp-admin/network/site-users.php.

props jeremyfelt.
fixes #27215.

Note: See TracTickets for help on using tickets.