WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27256 closed defect (bug) (fixed)

Unit test test_video_shortcode_body() fails

Reported by: ericlewis Owned by: SergeyBiryukov
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: has-patch
Focuses: Cc:
PR Number:

Description


Attachments (1)

27256.diff (1.1 KB) - added by ericlewis 6 years ago.

Download all attachments as: .zip

Change History (4)

@ericlewis
6 years ago

#1 @ericlewis
6 years ago

  • Keywords has-patch added

test_video_shortcode_body() was failing because test_constrain_size_for_editor_medium() and test_constrain_size_for_editor_full() were changing global $content_width manually, without cleaning up after themselves.

Made with love at WordCamp Lancaster contributor day with @georgestephanis @salcode @jorbin

Last edited 6 years ago by ericlewis (previous) (diff)

#2 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.9

#3 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 27358:

Restore $content_width global value after changing it in test_constrain_size_for_editor_*().

props ericlewis, georgestephanis, salcode, jorbin.
fixes #27256.

Note: See TracTickets for help on using tickets.