WordPress.org
Get WordPress

Make WordPress Core

Opened 19 years ago

Closed 18 years ago

#2726 closed defect (bug) (fixed)

irc://irc.server.org cannot be written into a post / link

Reported by: podz's profile Podz Owned by: skeltoac's profile skeltoac
Milestone: 2.1 Priority: normal
Severity: minor Version: 2.1
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

Put <a href="​irc://irc.server.org">IRC</a> into a post and it does not get rendered.

Put ​irc://irc.server.org as the external link using the toolbar and it prefixes with ​http://

IRC can't be linked from a blog

Attachments (3)

irc-kses.diff​ (734 bytes) - added by skeltoac 19 years ago.
admin-functions.php.diff​ (1.3 KB) - added by CSiefkes 18 years ago.
Patch that allows irc: links in the sidebar
allowed_protocols.diff​ (2.1 KB) - added by markjaquith 18 years ago.
Sync allowed protocols

Download all attachments as: .zip

Change History (7)

#1 @skeltoac
19 years ago

  • Keywords has-patch 2nd-opinion added
  • Milestone set to 2.1
  • Owner changed from anonymous to skeltoac
  • Severity changed from normal to minor
  • Status changed from new to assigned

It is not correct to conclude that "IRC can't be linked from a blog." You just have to be an admin so that your HMTL isn't filtered by KSES.

A patch is attached. Is there any reason an admin would not want this as an allowed protocol?

@skeltoac
19 years ago

#2 @CSiefkes
18 years ago

Not being able to use irc: links within posts is only part of the problem. It is also impossible to add irc: links to the sidebar using the Site Admin interface (link manager) -- they will always be prefixed by ​http:// . For sidebar links, it is impossible to work around this problem, since there is no graphical editor you could turn off to avoid filtering.

I'll attach a patch to wp-admin/admin-functions.php that fixes this other half of the problem.

@CSiefkes
18 years ago

Patch that allows irc: links in the sidebar

@markjaquith
18 years ago

Sync allowed protocols

#3 @markjaquith
18 years ago

There are some other protocols present in one place, but not in another. My patch syncs the lists (and reorders them so that they'll be easier to modify jointly in the future).

Any other places where some of the less common protocols are getting stripped out?

#4 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4550]) Update allowed protocols. fixes #2726

Note: See TracTickets for help on using tickets.