Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#27262 closed defect (bug) (fixed)

Use nooped plurals in wp_generate_tag_cloud()

Reported by: nacin Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:


#7989 introduce a fairly complex callback solution for changing the title attributes for tag cloud title tooltips. #14424 just eliminated the create_function() but thanks to the advent of nooped plurals, none of it is necessary. Patch attached.

Attachments (1)

27262.diff (5.0 KB) - added by nacin 8 years ago.

Download all attachments as: .zip

Change History (4)

8 years ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

8 years ago

#2 @nacin
8 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27376:

Accept nooped plurals in wp_generate_tag_cloud() / wp_tag_cloud().

Renders topic_count_text_callback more or less obsolete. It can still be used, but passing a plural is easier.

fixes #27262. see #7989, #14424.

#3 @DrewAPicture
5 years ago

@nacin Here's another one raised in #41121 for hard-deprecation: default_topic_count_text().

Looks like we adequately handle for the case where the callback is used in wp_generate_tag_cloud(), but it's not actually called anywhere. Has it outlived its usefulness?

Note: See TracTickets for help on using tickets.