Make WordPress Core

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#27264 closed enhancement (fixed)

Stop use of $domain and $path globals in ms_not_installed()

Reported by: jeremyfelt's profile jeremyfelt Owned by: jeremyfelt's profile jeremyfelt
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Bootstrap/Load Keywords: has-patch
Focuses: multisite Cc:

Description

We only use ms_not_installed() during the ms-settings.php bootstrap process and both $domain and $path are available to us at that time. We can pass these directly to the function rather than relying on the globals once inside the function.

Related: #25316:comment3

Attachments (1)

27264.diff (1.7 KB) - added by jeremyfelt 11 years ago.

Download all attachments as: .zip

Change History (5)

@jeremyfelt
11 years ago

#1 @jeremyfelt
10 years ago

  • Milestone changed from Future Release to 4.4

#2 follow-up: @jeremyfelt
10 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 33989:

Multisite: Remove $domain and $path globals in ms_not_installed()

Further reduces the reliance on these unnecessary globals.

Fixes #27264.

#3 in reply to: ↑ 2 ; follow-up: @dimadin
10 years ago

Replying to jeremyfelt:

There should be version 4.4 in changelog, not 4.3.

#4 in reply to: ↑ 3 @jeremyfelt
10 years ago

Replying to dimadin:

There should be version 4.4 in changelog, not 4.3.

Good catch, thanks!

Note: See TracTickets for help on using tickets.