WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27269 closed defect (bug) (fixed)

Missing styles for .spinner for HiDPI displays

Reported by: mauryaratan Owned by: SergeyBiryukov
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Administration Keywords: has-patch commit
Focuses: ui Cc:

Description

Added missing .spinner styling under /wp-admin/css/media.css

Attachments (4)

27269.diff (374.8 KB) - added by mauryaratan 6 years ago.
27269.2.diff (402 bytes) - added by mauryaratan 6 years ago.
Without minified file
27269.3.diff (887 bytes) - added by SergeyBiryukov 6 years ago.
27269.4.diff (1.2 KB) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (12)

@mauryaratan
6 years ago

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 3.9

No need to patch minified files, a post-commit task takes care of that.

There's a constant you can add to your wp-config.php file to use unminified files:
http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG

@mauryaratan
6 years ago

Without minified file

#2 @kovshenin
6 years ago

  • Keywords has-patch added

27269.2.diff looks good and works like a charm!

#3 @SergeyBiryukov
6 years ago

Looks like we already have this in common.css, but override it later in media.css:
trunk/src/wp-admin/css/common.css?rev=27289#L2336
trunk/src/wp-admin/css/media.css?rev=27403#L493

In 3.8, it was all in a single block:
tags/3.8.1/src/wp-admin/css/wp-admin.css#L11630.

Appears to be a result of the split in #26669. Should we perhaps remove it from common.css (27269.3.diff)?

Last edited 6 years ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in IRC in #wordpress-dev by kovshenin. View the logs.


6 years ago

#5 @SergeyBiryukov
6 years ago

27269.4.diff moves .spinner from media.css to common.css, per IRC, to avoid unintentional overriding.

Last edited 6 years ago by SergeyBiryukov (previous) (diff)

#6 @jonathanbardo
6 years ago

The latest patch works perfectly for me.

#7 @SergeyBiryukov
6 years ago

  • Keywords commit added

#8 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 27504:

Avoid unintentional overriding of .spinner styles for HiDPI displays.

props mauryaratan for initial patch.
fixes #27269.

Note: See TracTickets for help on using tickets.