WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #27278, comment 2


Ignore:
Timestamp:
03/05/2014 02:49:07 PM (6 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27278, comment 2

    initial v1  
    33> which adds support for the three types 'comment-list', 'comment-form' and 'search-form', but not the new type 'gallery'! Thus, as the code stands today 'gallery' is treated as a second-class citizen, which it does not deserve!
    44
    5 That list is just for backwards compatibility, new items should not be added there.
     5That list is just for backwards compatibility (see [25235]), new items should not be added there.
    66
    77[attachment:27278.4.diff] adds a `_doing_it_wrong()` call and a "Back compat" comment, per comment:12:ticket:26697. I think that's all we need here. We didn't do that originally, as the consensus in comment:12:ticket:24932 was that `_doing_it_wrong()` was not necessary until we actually had a new markup in some other function. Now that we've added it to `gallery_shortcode()`, let's do this.