WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #27279, comment 22


Ignore:
Timestamp:
03/29/2014 08:59:23 PM (8 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27279, comment 22

    v1 v2  
    11Looking at 27279.5.patch:
    2 - `#qt_content_fullscreen` will only work when the editor ID is `content`. There's nothing stopping us to add classes to the Quicktags buttons, that would also improve the existing styling.
     2- `#qt_content_fullscreen` will only work when the editor ID is `content`. There's nothing stopping us to add classes to the Quicktags buttons, that would also improve the existing styling for b, i, link, etc.
    33- Changing the styling for `.mce-btn-group` would introduce discrepancies when "button groups" are used. TinyMCE has the notion of grouping the buttons and keeping these groups together when the toolbar is wrapped. Groups are separated with `|` when defining button order. This is not used by default in WordPress, but can be added by a plugin.
    44- `!important` is evil! :) There are plenty of nested elements and selectors that can be used to override some style.