Opened 13 years ago
Closed 12 years ago
#27283 closed enhancement (fixed)
WP_Date_Query missing column user_registered
| Reported by: | ChriCo | Owned by: | boonebgorges |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.1 |
| Component: | Query | Version: | 3.8 |
| Severity: | normal | Keywords: | has-patch commit needs-docs |
| Cc: | Focuses: |
Description
In WP_Date_Query-Class theres a missing column "user_registered" and no support for it in WP_User_Query.
We've to add the missing Column in WP_Date_Query-Class on Method validate_column and add the query_var on WP_User-Query-Class.
Attachments (2)
Change History (12)
#2
@
12 years ago
- Keywords has-patch needs-refresh added
- Milestone Awaiting Review → 4.0
I like where this is going
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
12 years ago
#4
@
12 years ago
- Keywords commit needs-unit-tests added; needs-refresh removed
- Milestone 4.0 → Future Release
I uploaded a cleaned up patch. Looking at the tests, though, it doesn't look like there are any functional assertions here. It's simply comparing that the SQL output of a WP_Date_Query instance is returning the same WHERE as the WP_Date_Query instance inside WP_User_Query. That's insufficient as they could all be returning nothing and the whole thing would pass.
We need to essentially borrow Tests_Comment_DateQuery or Tests_Query_DateQuery and make our own Tests_User_DateQuery in tests/phpunit/user/datequery.php.
Moving out of 4.0, though this is simple enough we can bring it back in if tests are written.
#6
@
12 years ago
- Keywords needs-unit-tests removed
- Milestone Future Release → 4.1
- Owner set to
- Status new → accepted
I got this.
#8
follow-up:
↓ 9
@
12 years ago
- Keywords needs-docs added
- Resolution fixed
- Status closed → reopened
Let's add a line to the filter changelog about the new column added to the array, please :-)
#9
in reply to: ↑ 8
@
12 years ago
Replying to DrewAPicture:
Let's add a line to the filter changelog about the new column added to the array, please :-)
Oh, you.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Added patch with unit-tests