WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27305 closed defect (bug) (fixed)

Command+K on Mac launches TinyMCE native link modal

Reported by: chrisvanpatten Owned by: azaozz
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: TinyMCE Keywords:
Focuses: ui, administration Cc:

Description

Hi all -

I'm running WordPress 3.9 trunk (3.9-alpha-27368) on our site (vanpattenmedia.com) and have noticed that the Command+K keyboard command triggers TinyMCE's native Bootstrappy 'New Link' modal, instead of WordPress'. Command+K never worked in previous versions of WordPress, so I'm assuming this mapping was introduced with the new TinyMCE.

I'm attaching a screenshot for evidence.

In my ideal world (for me at least), Command+K continues to function (parity with Gmail, Google Docs, TinyMCE core, etc.), but loads the WordPress-native link modal instead of the TinyMCE's native option.

P.S. There is probably a Windows equivalent of this shortcut as well. Perhaps just Ctrl+K?

Attachments (2)

Screen Shot 2014-03-06 at 17.13.43.png (64.9 KB) - added by chrisvanpatten 6 years ago.
Screenshot evidence
27305.insert-link.png (13.7 KB) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (9)

@chrisvanpatten
6 years ago

Screenshot evidence

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.9

#2 @helen
6 years ago

The link shortcut now is opt-shift-A - should we change that? Have both shortcuts?

#3 @chrisvanpatten
6 years ago

I think Command+K is becoming a sort of de-facto "standard" (as much as such a thing can be). It's used by Gmail, Google Docs, Apple Mail, Pages, TinyMCE, and I'm sure many others. I think it might make sense to keep both opt-shift-A (for legacy reasons, although I had no idea existed until now, I have to confess) and command-K intact for those used to that convention.

Last edited 6 years ago by chrisvanpatten (previous) (diff)

#4 @SergeyBiryukov
6 years ago

Command+K keyboard command triggers TinyMCE's native Bootstrappy 'New Link' modal, instead of WordPress'.

I also get a weird arrow in the lower right corner in both Firefox and Chrome: 27305.insert-link.png.

P.S. There is probably a Windows equivalent of this shortcut as well. Perhaps just Ctrl+K?

Ctrl+K, yes.

#5 @helen
6 years ago

I'm down with having both keyboard shortcuts, although sometimes I'm pretty sure I'm the only person who uses the current one :)

#7 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 27449:

TinyMCE: add Ctrl+K, the "de-facto standard" shortcut to open wpLink, fixes #27305

Note: See TracTickets for help on using tickets.