Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#27308 closed defect (bug) (fixed)

jshint:themes should only run against the core themes we want it run against

Reported by: jorbin's profile jorbin Owned by: helen's profile helen
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Right now, grunt jshint:themes will test any js in src/wp-content/themes that isnt' in twenty{eleven,twelve,thirteen} (and also isn't a single specified 3rd party script in twentyfourteen).

Sometimes you want to have other themes in your checkout. Examples include testing update notifications or testing theme apis. We should avoid these themes in our test.

Attachments (1)

jshint-themes.diff (400 bytes) - added by jorbin 10 years ago.

Download all attachments as: .zip

Change History (5)

#1 @jorbin
10 years ago

  • Keywords has-patch added

The above patch causes us to look only at twenty* directories when running jshint.

This ticket was mentioned in IRC in #wordpress-dev by jorbin. View the logs.


10 years ago

#3 @SergeyBiryukov
10 years ago

  • Description modified (diff)
  • Keywords commit added
  • Summary changed from jshint:themes should only run agaignst the core themes we want it run againgst to jshint:themes should only run against the core themes we want it run against

#4 @helen
10 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 27446:

Be more specific about which themes we want to jshint. props jorbin. fixes #27308.

Note: See TracTickets for help on using tickets.