Fix the "Link" button's disabled state

[azaozz]

The behavior of the link dialog in TinyMCE 4.0 has changed. Now it is possible to open it without selecting text or image. Then the dialog has another field where the linked text can be added, ​example.

As a result the "link" button is not set to disabled. This is confusing as links cannot be added with the wpLink dialog without selecting text or image.

[SergeyBiryukov]

Related: #27305

[azaozz]

In 27447:

TinyMCE:

• Restore the "link" button state to disabled by default and enabled when text or image is selected.
• Remove the (recently added) default link plugin, not needed for wpLink.

See #27309

[azaozz]

Leaving open for considering if wpLink should be updated to offer the same workflow as the default link plugin.

[iseulde]

Now the link button is disabled when you don't select text, but the unlink button is still active when the cursor is not inside a link.

[azaozz]

Replying to avryl:

...the unlink button is still active when the cursor is not inside a link.

This is the same as in 3.8. Can easily be set to disabled when the caret is not in a link. The problem is the Unlink button has only two states: can remove | cannot remove. Trying to match that to disabled | enabled | highlighted wouldn't work :)

It's a bit more problematic to enable it when there is a selected text and part of that text is in a link. Then clicking Unlink removes the partially selected link. Can try to patch it so it looks inside selected text when it spans more than one node and set it to 'enabled'. Will still be somewhat inconsistent, if it can remove a link it should be highlighted?

[iseulde]

It just looks really weird when your cursor is not inside a link and there is nothing to unlink (and the link button isn't active, but the unlink button is).

[nacin]

Replying to avryl:

It just looks really weird when your cursor is not inside a link and there is nothing to unlink (and the link button isn't active, but the unlink button is).

I agree.

I recall us discussing in IRC that it should only be "active" when your cursor is in a link, or your selection contains one or more links.

[azaozz]

In 27934:

TinyMCE: improve setting disabled/enabled/activated states on the Unlink button, fixes #27309