Easier adding of custom class variables when extending WP_Customize_Section

[rhurling]

WP_Customize_Section uses $keys = array_keys( get_class_vars( __CLASS__ ) ); to set class variables, but WP_Customize_Control uses $keys = array_keys( get_object_vars( $this ) ); to set class variables.

The difference is that if you extend WP_Customize_Control you can add new class variables by setting them in the extended class and passing them to the args array in the constructor.
In WP_Customize_Section one has to override the constructor to do the same.

changing

$keys = array_keys( get_class_vars( __CLASS__ ) );

to

$keys = array_keys( get_object_vars( $this ) );

in WP_Customize_Section would solve the problem (or use the static keyword which would raise the requirements to PHP 5.3)

[westonruter]

Agreed. get_class_vars( __CLASS__ ) should be replaced with get_object_vars( $this ). This would actually bring WP_Customize_Section in line WP_Customize_Control which initially did use get_class_vars() but in [20319] was changed to use get_object_vars().

[westonruter]

Also, WP_Customize_Setting currently uses get_class_vars( __CLASS__ ) like WP_Customize_Section. It should be updated to use get_object_vars( $this ) as well.

[rhurling]

okay, i'll try to make a patch today

[rhurling]

replace get_class_vars with get_object_vars

[SergeyBiryukov]

In 28827:

Allow for easier adding of custom class variables when extending WP_Customize_Section or WP_Customize_Setting.

props rhurling.
fixes #27315.