WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#27358 closed defect (bug) (fixed)

Widget Customizer: Improve behavior of widget highlighting

Reported by: westonruter Owned by: ocean90
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Widgets Keywords: has-patch ui-feedback
Focuses: ui, javascript Cc:

Description

Regarding the Widget Customizer merge #27112, when you hover over a widget in the customizer panel, the corresponding widget in the preview gets a highlight. Currently the widget gets this highlight via a red box-shadow and leaves much room for improvement. Additionally, the widget in the preview should scroll into view. Correspondingly, when hovering of a widget in the preview the corresponding widget control in the customizer panel gets a highlight, as does the containing customizer section.

See also:
https://github.com/x-team/wp-widget-customizer/issues/85
https://github.com/x-team/wp-widget-customizer/issues/56
https://github.com/x-team/wp-widget-customizer/pull/16

Attachments (3)

27358.diff (3.2 KB) - added by westonruter 7 years ago.
Restore Widget Customizer highlighting of widgets in preview. Also on GitHub: https://github.com/x-team/wordpress-develop/pull/2
27358.2.diff (511 bytes) - added by westonruter 7 years ago.
Fix Firefox shift+click problem to open widget due to apparent difference with Chrome in how jQuery implements :focusable selector. Specify focus on first focusable element inside .widget-content, and remove click trigger now handled by expandForm()
27358.3.diff (1.2 KB) - added by ocean90 7 years ago.

Download all attachments as: .zip

Change History (13)

#1 @samuelsidler
7 years ago

  • Milestone changed from Awaiting Review to 3.9

#2 @ocean90
7 years ago

  • Focuses ui added
  • Keywords needs-patch added

when you hover over a widget in the customizer panel, the corresponding widget in the preview gets a highlight.

Seems like this is either broken or removed.

Not sure if some scrolling in the controls and/or preview on widget mouseover could be to noisy.

@westonruter
7 years ago

Restore Widget Customizer highlighting of widgets in preview. Also on GitHub: https://github.com/x-team/wordpress-develop/pull/2

#3 @westonruter
7 years ago

  • Keywords has-patch added; needs-patch removed

I've fixed the broken highlight, restoring the original Widget Customizer behavior. It should be further improved beyond this.

#4 @ocean90
7 years ago

  • Keywords ui-feedback added

27358.diff was committed in [27584].

#5 @ocean90
7 years ago

Helen mentioned, that shift click doesn't work in Firefox. It opens the widget, but immediately closes again.

#6 @nacin
7 years ago

  • Type changed from enhancement to defect (bug)

Getting this off the enhancements report.

@westonruter
7 years ago

Fix Firefox shift+click problem to open widget due to apparent difference with Chrome in how jQuery implements :focusable selector. Specify focus on first focusable element inside .widget-content, and remove click trigger now handled by expandForm()

#7 @ocean90
7 years ago

In 27701:

Widget Customizer: Fix shift+click issue in Firefox to open a widget.

props westonruter.
see #27358.

#8 @ocean90
7 years ago

In 27702:

Widget Customizer: Improve widget highlighting.

  • Prefix box-shadow in inject_preview_css()
  • Remove border-radius in inject_preview_css()
  • Prevent hidden box-shadows in Customizer

see #27358.

@ocean90
7 years ago

#9 @ocean90
7 years ago

27358.3.diff uses the same colors as in [27741].

#10 @ocean90
7 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 27814:

Widget Customizer: Set hightlight color to blue. Same color as in [27741].

fixes #27358.

Note: See TracTickets for help on using tickets.