Changes between Initial Version and Version 1 of Ticket #27359, comment 19
- Timestamp:
- 04/20/2014 08:31:57 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #27359, comment 19
initial v1 9 9 - It's a bit unclear what happens after the user has selected a color by dragging the "handle". Would be good to have "OK" or "Apply" button. 10 10 - The tiny "color bar" under the icon in the button is intended to keep the last selected color value and apply it on clicking the button. It shouldn't change according to the current node's color. 11 - Thinking the "live preview" inside the editor while selecting a color/dragging the handle is not needed. The text where the color is going to be applied is usually selected at this tile. That makes the "live preview" invisible. It also seems to make dragging of the handle to lag. If you decide to keep it, it will need to be wrapped in `editor.undoManager.transact()` so it doesn't add new undo level on every color change.11 - Thinking the "live preview" inside the editor while selecting a color/dragging the handle is not needed. The text where the color is being applied is usually selected at this time (blue background/white text). That makes the "live preview" invisible. It also seems to make dragging of the handle to lag. If you decide to keep it, it will need to be wrapped in `editor.undoManager.transact()` so it doesn't add new undo level on every color change. 12 12 - The CSS selectors need to be more specific so they don't override other instances of Iris. 13 13