WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#27360 closed defect (bug) (fixed)

Invalid model id on themes page

Reported by: mauryaratan's profile mauryaratan Owned by: nacin's profile nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Themes Keywords: has-patch commit
Focuses: Cc:

Description

As soon as I click on a theme on themes page, theme query parameter is updated to ?theme=undefined. If you hit the refresh the page right after that, you’ll get error Cannot read property 'id' of undefined coming from /wp-admin/theme.js:685.

Tried to fix it, but still a noob with backbone.js ;(

Attachments (1)

27360.patch​ (367 bytes) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.9

Confirmed.

#2 @SergeyBiryukov
12 years ago

Introduced in [27499].

@SergeyBiryukov
12 years ago

#3 @SergeyBiryukov
12 years ago

  • Keywords has-patch added

27360.patch​ fixes it for me. slug is only available on Add Themes screen.

#4 @mauryaratan
12 years ago

Works like a charm.

#5 @SergeyBiryukov
12 years ago

  • Keywords commit added

#6 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27509:

Use correct variable in themes JS, fixes themes.php.

props SergeyBiryukov.
fixes #27360.

Note: See TracTickets for help on using tickets.