WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #27365, comment 23


Ignore:
Timestamp:
10/23/2015 08:40:15 AM (9 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #27365, comment 23

    initial v1  
    88Based on that, [attachment:27365.2.diff 27365.2.diff] does what's intended, the results from `bulk_upgrade()` now match what you'd expect.
    99
     10
     11Now, on the flip-side... Lets look at a life without `$this->result` having errors in it at all..
     12
    1013So if you take `$this->result` as mostly intended for a way for `WP_Upgrader` to pass details of what it had operated on to `WP_Upgrader_Skin`, so it could pull in contextual information (ie. plugin name/version) I think, then there was no need for it to ever store errors in `$this->result` as it was also calling `$this->skin->error($error)`.
    1114