Context Navigation

Changes between Initial Version and Version 1 of Ticket #27365, comment 6

initial	v1
1	1	johnbillion suggested that I provide details about what the `$this->result` variable is.
2	2
3		Digging through the code, it is set (as far as upgrading is concerned) by the `WP_Upgrader::install_package()` function. After the `install_package()` function runs, the `$this->result` variable contains the value returned by the function. Since this value is ultimately returned by the `WP_Upgrader::run()` function, it would seem that this result would be seen in successful upgrade responses. In my testing, I would see null responses even on successful upgrades, so I'm not sure what accounts for that issue.
	3	Digging through the code, it is set (as far as upgrading is concerned) by the `WP_Upgrader::install_package()` function. After the `WP_Upgrader::install_package()` function runs, the `$this->result` variable contains the value returned by the function. Since this value is ultimately returned by the `WP_Upgrader::run()` function, it would seem that this result would be seen in successful upgrade responses. In my testing, I would see null responses even on successful upgrades, so I'm not sure what accounts for that issue.
4	4
5	5	Even if the proper response was contained in `$this->result`, using it in this spot is still a poor decision as it would only contain the response from the `WP_Upgrader::install_package()` function and not the error responses that `WP_Upgrader::run()` returns before calling `WP_Upgrader::install_package()`.