Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #27403, comment 57


Ignore:
Timestamp:
10/12/2016 11:55:15 PM (9 years ago)
Author:
sirbrillig
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27403, comment 57

    initial v1  
    22
    33This is a very good point. I'm sure we can make these icons better supported, but my CSS skills are limited. If anyone wants to take a crack at it, please do!
     4
     5Another point only briefly touched on above is that with the icons added to the page, they:
     6A) can affect the page layout, and
     7B) don't hover over elements which are absolutely positioned.
     8
     9Twentythirteen is a good example of a theme which has both issues. The menu icon causes the menu area to become twice as thick and the footer widgets are all positioned away from their icons.
     10
     11Making the icons absolutely positioned "solves" this by removing the icons from the document flow. Unfortunately this opens another can of worms. It requires very careful positioning to prevent the icon from completely covering its target, not falling off the page, not appearing to relate to another page element, etc. Also when certain DOM changes take place (eg: repositioning widgets in Twentythirteen) the icons do not automatically follow, so we must listen to all sorts of changes and perform manual repositions.
     12
     13The implementation on wp.com does all of these things to support the widest array of themes possible, and we're still tweaking it every so often. I was hoping to avoid the issue in core, but unless we disable this feature for certain themes, I'm starting to see us going down the same road.