Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #27403, comment 57


Ignore:
Timestamp:
10/13/2016 12:00:59 AM (9 years ago)
Author:
sirbrillig
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27403, comment 57

    v1 v2  
    99Twentythirteen is a good example of a theme which has both issues. The menu icon causes the menu area to become twice as thick and the footer widgets are all positioned away from their icons.
    1010
     11[[Image(https://cldup.com/nREXTndVC9.png)]]
     12
    1113Making the icons absolutely positioned "solves" this by removing the icons from the document flow. Unfortunately this opens another can of worms. It requires very careful positioning to prevent the icon from completely covering its target, not falling off the page, not appearing to relate to another page element, etc. Also when certain DOM changes take place (eg: repositioning widgets in Twentythirteen) the icons do not automatically follow, so we must listen to all sorts of changes and perform manual repositions.
    1214
     15[[Image(https://cldup.com/LWRuQNfF2d.png)]]
     16
    1317The implementation on wp.com does all of these things to support the widest array of themes possible, and we're still tweaking it every so often. I was hoping to avoid the issue in core, but unless we disable this feature for certain themes, I'm starting to see us going down the same road.
     18
     19[[Image(https://cldup.com/-iIw6EMGvJ.png)]]