#27426 closed defect (bug) (fixed)
Unit Tests for i18n and wptexturize
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 4.0 | Priority: | normal |
| Severity: | normal | Version: | 3.8 |
| Component: | Formatting | Keywords: | wptexturize has-patch |
| Focuses: | Cc: |
Description
There are some predictable bugs not being tested yet:
$apos = _x( '’', 'apostrophe' );
$closing_single_quote = _x( '’', 'closing curly single quote' );
if ( "'" != $apos )
$dynamic[ '/(\S)\'([^\'\s])/' ] = '$1' . $apos . '$2';
By that logic, quotations with outside punctuation will never work correctly.
'This is a test quote'.
becomes...
{$opening_single_quote}This is a test quote{$apos}.
It is easy to miss this bug because closing quotes and apostrophes are identical by default.
Attachments (2)
Change History (11)
This ticket was mentioned in IRC in #wordpress-dev by miqrogroove. View the logs.
12 years ago
Note: See
TracTickets for help on using
tickets.
The regexp might need another tweak. The bug is fixed for a period outside the quotes, but commas and other chars might be common too.