Warning on WP Media List Table when Custom Post Type No Longer Active

[wpsmith]

Currently, with a custom post type that no longer exists, a Media object that is attached to a post in that custom post type throws a warning.
​Screenshot

To Repeat Warning:

1. Create a custom post type via functions.php or a plugin.
2. Create a new post
3. Upload an image to that custom post type as a featured image
4. Comment custom post type code in functions.php or deactivate plugin.
5. Go to Media Library (domain.com/wp-admin/upload.php)

You will see the warning in the Uploaded to column.

[wpsmith]

First pass

[SergeyBiryukov]

Introduced in [25140]. Previously: #22312.

[SergeyBiryukov]

In 27560:

Avoid PHP notices in Media Library if an attachment parent post type no longer exists.

props wpsmith.
fixes #27439.

[SergeyBiryukov]

#27446 was marked as a duplicate.

[afercia]

sorry Sergey, maybe I'm in a dumb moment but I still can see those PHP notices.. please check attached screenshot, where you can see I'm testing on trunk 27615.

Just checking capabilities.php on line 1112, seems to me that $post_type at that point is NULL, and that's (and following lines) the reason for the notices.

[SergeyBiryukov]

Replying to afercia:

sorry Sergey, maybe I'm in a dumb moment but I still can see those PHP notices.

You're right, I've reopened #27446 for 4.0. See #16956 for map_meta_cap() fixes in a future release.

[afercia]

Replying to SergeyBiryukov:

You're right, I've reopened #27446 for 4.0. See #16956 for map_meta_cap() fixes in a future release.

Yup, I've seen that, thank you very much Sergey.