Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#27456 closed defect (bug) (fixed)

Twenty Fourteen: Menu toggle text displays on some Android devices

Reported by: zoonini's profile zoonini Owned by: lancewillett's profile lancewillett
Milestone: 4.0 Priority: low
Severity: normal Version: 3.9
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Multiple users report that the menu-toggle text - "Primary Menu" or equivalent in other languages" - is visible and overlaps the hamburger icon on certain Android devices, running the default browser that comes with the OS.

Example site 1: http://www.burnthis.se/

Example screenshot 1: http://i.imgur.com/Hmoc5MG.png

Example screenshot 2: http://i.imgur.com/rVpXKMW.png (site has since switched themes)

The same issue is seen by these users on the WordPress.com demo site: http://twentyfourteendemo.wordpress.com/

Example phone/OS experiencing the issue:

  • Android 2.3.6 - Samsung Ace 2 - default browser

The issue is not present on iOS - the menu-toggle text is invisible, as intended.

Forum thread: http://wordpress.org/support/topic/menu-toggle-shows-text-in-android-236

Attachments (3)

android-chrome-nexus5.png (225.9 KB) - added by lancewillett 11 years ago.
Android Chrome on Nexus 5
27456.diff (569 bytes) - added by obenland 11 years ago.
27456.1.diff (404 bytes) - added by schoenwaldnils 10 years ago.

Download all attachments as: .zip

Change History (16)

@lancewillett
11 years ago

Android Chrome on Nexus 5

#1 @lancewillett
11 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Noting it's working as expected on Chrome on Android 4.4.2.

This ticket was mentioned in IRC in #wordpress-themes by lancewillett. View the logs.


11 years ago

@obenland
11 years ago

#3 @obenland
11 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

I don't have an Android device, so I have no idea if the patch works :)

#4 @lancewillett
11 years ago

Does anyone know the % of Android devices on that old platform? "Android 2.3.6" seems like a quite old platform, right?

#5 @zoonini
11 years ago

I found these stats from January 2014:

http://androidandme.wpengine.netdna-cdn.com/wp-content/uploads/2014/01/androiddistributionjanaam.jpg

Android 2.3.6 looks like it's part of the second-largest usage band (21.2%), Gingerbread.

Reference: http://developer.android.com/about/dashboards/index.html?utm_source=ausdroid.net

#6 @lancewillett
11 years ago

  • Milestone changed from Future Release to 4.0
  • Priority changed from normal to low

This ticket was mentioned in IRC in #wordpress-themes by lancewillett. View the logs.


11 years ago

#8 @DavidTheMachine
11 years ago

Testing at WordCamp Orange County with lancewillet, installed the Android SDK, emulating Gingerbread (2.3.3), and confirmed bug and that patch works.

#9 @obenland
11 years ago

  • Keywords commit added; needs-testing removed
  • Version set to 3.9

#10 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 28698:

Twenty Fourteen: fix menu toggle display on older Android devices. Props obenland, DavidTheMachine. Fixes #27456.

#11 @schoenwaldnils
10 years ago

27456.1.diff​ fixes that the dots on the german Ä in PRIMÄRES MENÜ appear in the menu-toggle-button

#wchh14

Before:
http://puu.sh/9w1Xp/bbb276f8a6.png

After:
http://puu.sh/9w1Wq/6fbd0f1103.png

#12 @obenland
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#13 @ocean90
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 28756:

Twenty Fourteen: Adjust spacing for menu toggle button to avoid overflowing accented characters.

Broken in [28698].

props schoenwaldnils.
fixes #27456.

Note: See TracTickets for help on using tickets.