WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#27457 closed defect (bug) (fixed)

Avoid undefined function fatal on quickdraft save

Reported by: obenland's profile obenland Owned by: helen's profile helen
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

In case it comes to an error when a quickdraft is saved, the call to wp_dashboard_quick_press() returns in a fatal error because wp-admin/includes/dashboard.php doesn't get included until a few lines later.

Introduced in r26144 (specifically here).

Attachments (1)

27457.diff​ (793 bytes) - added by obenland 11 years ago.

Download all attachments as: .zip

Change History (5)

@obenland
11 years ago

This ticket was mentioned in IRC in #wordpress-dev by obenland. ​View the logs.
11 years ago

#2 @helen
11 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 27630:

Avoid an undefined function due to /wp-admin/includes/dashboard.php being included too late. props obenland. fixes #27457.

#3 follow-up: @nacin
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Can we double-check that the error condition actually works now? Since it's always been broken..

#4 in reply to: ↑ 3 @helen
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to nacin:

Can we double-check that the error condition actually works now? Since it's always been broken..

I did :)

Note: See TracTickets for help on using tickets.