WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#27460 closed enhancement (fixed)

Add A/V Thumbnail support to our Default Themes

Reported by: mikeschroder Owned by: wonderboymusic
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: administration Cc:

Description (last modified by mikeschroder)

Per @wonderboymusic's recommendation, we should either enable A/V thumbnail support globally, or specifically within each of our default themes shipped.

Audio and Video playlists are best viewed including their covers, and it feels broken to not do so along with the other support added in 3.9.

Related: #26631

Attachments (1)

27460.diff (4.2 KB) - added by wonderboymusic 5 years ago.

Download all attachments as: .zip

Change History (7)

#1 @mikeschroder
6 years ago

  • Description modified (diff)

#2 @lancewillett
6 years ago

Possibly related: #27243 — should this ticket be in "Bundled Theme" component or "Media" maybe?

#3 @mikeschroder
6 years ago

  • Component changed from Themes to Bundled Theme

Yes, it should, thanks! Done.

@wonderboymusic
5 years ago

#4 @wonderboymusic
5 years ago

  • Component changed from Bundled Theme to Media
  • Focuses administration added; ui template removed
  • Keywords has-patch added; needs-patch removed

27460.diff turns on thumbnail support for attachment:audio and attachment:video. The thumbnail meta box was already showing up if theme OR post type support was turned on, so I changed the other conditions to check the same. I wrote those original conditionals in 3.6, when there wasn't a pressing need for images, there is now since playlists.

Rather than having every single theme on Earth turn on the feature, we're turning it on at post type level, so the theme only needs to turn it on if a plugin for some reason turns it off.

#5 @wonderboymusic
5 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 27657:

Turn on thumbnail support for attachment:audio and attachment:video. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin.

Fixes #27460.

#6 @wonderboymusic
5 years ago

In 27659:

When inserting a video shortcode into the editor, set the poster attribute automatically if the video has a featured image attached to it.

See #27460.

Note: See TracTickets for help on using tickets.