WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#27463 closed defect (bug) (invalid)

TinyMCE buttons markup changed in WP 3.9 Beta 1

Reported by: dennis_f Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.9
Component: TinyMCE Keywords: close
Focuses: ui, accessibility Cc:

Description

I have noticed that the TinyMCE buttons markup has changed, which makes the custom buttons that we have created invisible, as the CSS selectors used to set the icons don't match anymore.

For example, in 3.8 the following selector is used to set the blockquote button icon (in wp-includes/css/editor.css):

span.mce_blockquote:before

and in 3.9 the following selector is used instead:

i.mce-i-blockquote:before

I understand that this is probably the default markup of TinyMCE 4.0, but I just wanted to report this issue in case there could be some kind of solution to keep the old selectors working, so that there are fewer issues with the buttons that the plugin/theme developers create.

Here is how my custom buttons look like on WP 3.9 Beta 1 - empty line, there are several buttons added to the third line (I have highlighted one of the buttons with the browser developer tools, just to show that it is there):
http://imageshack.com/a/img703/566/j4ja.png

Change History (2)

#1 @azaozz
5 years ago

  • Keywords close added

I understand that this is probably the default markup of TinyMCE 4.0, but I just wanted to report this issue in case there could be some kind of solution to keep the old selectors working...

Unfortunately no, the old markup used tables and spans, the new uses <div>, <button> and <i>. Even if there was a way to fix this, it would still be a good idea to update any plugin that adds buttons to TinyMCE as there are quite a few other changes.

#2 @jeremyfelt
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing per @azaozz's note. Thanks for the report @dennis_f.

Note: See TracTickets for help on using tickets.