Make WordPress Core

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#27480 closed enhancement (wontfix)

Reset state if user closes Media modal

Reported by: ericlewis's profile ericlewis Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Media Keywords: close
Focuses: ui, javascript Cc:

Description

If a user begins creating a gallery, but cancels in the middle of the process by closing the modal, clicking the Add Media button brings them back into the workflow where they left off. I think we should reset the state of the modal when you close it.

Attachments (4)

27480.mov (1.9 MB) - added by ericlewis 10 years ago.
27480.diff (425 bytes) - added by ericlewis 10 years ago.
27480.1.diff (493 bytes) - added by ericlewis 10 years ago.
derp
27480.2.diff (518 bytes) - added by ericlewis 10 years ago.

Download all attachments as: .zip

Change History (15)

@ericlewis
10 years ago

#1 @ericlewis
10 years ago

attachment:27480.mov shows you the current functionality.

@ericlewis
10 years ago

#2 @ericlewis
10 years ago

attachment:27480.diff triggers reset and loads the default state to the controller inside the escape handler.

This ticket was mentioned in IRC in #wordpress-dev by wonderboymusic. View the logs.


10 years ago

@ericlewis
10 years ago

derp

@ericlewis
10 years ago

#4 @ericlewis
10 years ago

In attachment:27480.2.diff, this logic should live within the escape method instead of the escapeHandler, which is responsible for capturing the click event.

#5 @nacin
10 years ago

The original intent of the modal was to retain state. It works really well for that. I've sometimes closed the modal to check something, then re-open it. (Which is not something you could do with the old iframe — which was also slow, versus being instantaneous.) I don't think we should change this.

#6 @kirasong
10 years ago

If we're going to maintain state, perhaps the name of the button shouldn't be "Add Media"?

I'd be interested in seeing user tests on this, but when I click a button that specifically notes it's going to add or insert something, rather than "Manage" or like, I expect it to be at a fresh state, similar to the buttons that open modals in MCE.

I understand that it's useful, but it's not the behavior I expected at all when using it, due to its difference from the way other modals work within the screen.

Last edited 10 years ago by kirasong (previous) (diff)

#7 @sonjanyc
10 years ago

From a UX perspective I agree with Mike, retaining state isn't expected behavior, but I also agree with Nacin that this functionality can be very valuable.

How about when closing the modal we ask the user if he wants to save the state?
We could ask every time if the user wants to save or dismiss, or we could maybe also add an option to "always save" or "never save". This would add another layer to the modal, not really ideal.
So maybe adding a "save and close" button/link in the UI of the media modal might make more sense. (naming obviously open for ideas!)

http://new.tinygrab.com/00a07a89c67ac9f20d8dcdafc154c463750ac01ee6.png

Thoughts?

#8 @SergeyBiryukov
10 years ago

  • Version changed from trunk to 3.8

#9 @ericlewis
9 years ago

  • Keywords close added

I'm not sure we can do anything to help with discovery here. Let's just accept this as a peculiarity of the UI.

#10 @wonderboymusic
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

#11 @wonderboymusic
9 years ago

  • Resolution changed from maybelater to wontfix
Note: See TracTickets for help on using tickets.