Widget Customizer: WidgetCustomizerPreview is undefined in IE8/9

[ocean90]

Message: 'WidgetCustomizerPreview' is undefined
Line: 310
Char: 4
Code: 0
URI: http://trunk.wp.dev/wp-admin/customize.php?theme=twentyfourteen

[SergeyBiryukov]

#27486 was marked as a duplicate.

[ocean90]

27485.patch​:

• Moves WidgetCustomizerPreview_exports to export_preview_data() too and combines data to _wpWidgetCustomizerPreviewSettings
• Moves WidgetCustomizerPreview to wp.customize.WidgetCustomizerPreview
• snake_case to CamelCase

[adamsilverstein]

Looks good - I tested this under Windows XP/IE8 and Windows 7 IE8 & IE9 - after the patch is applied the console errors go away when initially loading the page.

Trying to add a widget however, yields a different error - i believe caused by IE8's lack of support for indexOf on arrays: ​http://cl.ly/image/302447300A1J. Working on a fix.

[adamsilverstein]

use underscores indexOf for IE8 compatibility

[adamsilverstein]

27485.2.patch​ builds on 27485.patch​ and improves IE8 compatibility for the Widget Customizer by swapping JavaScript indexOf (not supported for Arrays in IE8), instead using Underscore's _.indexOf (which provides an IE8 fallback). Other than the order of passed variables, nothing else changes between indexOf and _.indexOf so I don't anticipate unexpected side effects.

After applying this patch I no longer see console errors and I amble to add and remove widgets. One remaining IE8 issue is that when I click the Save & Publish button although the settings are saved, the button does not update to the text 'Saved' as it does in other browsers. No console errors, just no change in the button. Digging more to see why that is.

[ocean90]

In 27653:

Widget Customizer: Fix 'WidgetCustomizerPreview' is undefined error in IE8/9.

• Move WidgetCustomizerPreview to wp.customize.WidgetCustomizerPreview
• Move WidgetCustomizerPreview_exports to export_preview_data()
• Use _wpWidgetCustomizerPreviewSettings to transfer settings to wp.customize.WidgetCustomizerPreview

see #27485.

[ocean90]

In 27654:

Widget Customizer: Use Underscores indexOf for IE8 compatibility.

props adamsilverstein.
see #27485.

[adamsilverstein]

Replying to ocean90:

In 27654:

Widget Customizer: Use Underscores indexOf for IE8 compatibility.

props adamsilverstein.
see #27485.

Thanks, I think we can close this ticket.

The other issue I mentioned (the button not changing to Saved) is also present in WordPress 3.8.1 and deserves a separate ticket. I think the bound change handler is failing to fire - this looks like its binding right on an object does not trigger correctly in IE8 (ref)

[ocean90]

Replying to adamsilverstein:

The other issue I mentioned (the button not changing to Saved) is also present in WordPress 3.8.1 and deserves a separate ticket.

Yes please.

[westonruter]

Some of the indexOf instances were actually String.indexOf() not Array.indexOf() so they need to be reverted. Attaching patch.

[westonruter]

Revert some of the indexOf() replacements doing in r27654, as they were methods on Strings not Arrays.

[adamsilverstein]

Replying to westonruter:

Some of the indexOf instances were actually String.indexOf() not Array.indexOf() so they need to be reverted. Attaching patch.

Ack! Good catch, these shouldn't have been changed.

[ocean90]

In 27890:

Revert [27654] for strings.

props westonruter.
fixes #27485.