WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#27504 closed defect (bug) (fixed)

Widget Customizer: Add pre_update_option filter, replace Options_Transaction

Reported by: ocean90 Owned by:
Milestone: 3.9 Priority: high
Severity: major Version: 3.9
Component: Customize Keywords: has-patch
Focuses: Cc:

Description (last modified by westonruter)

The plan was to remove Options_Transaction completely, but we can't at least not for the old single widgets.

I'm attaching the patch from #27112 where Options_Transaction is now Option_Update_Capture.
The goal should be, to use Option_Update_Capture only for old single widgets.

Previously reported and resolved wontfix in #13836

Attachments (5)

27112.no-options-transaction.diff (7.8 KB) - added by ocean90 7 years ago.
27504.diff (8.5 KB) - added by westonruter 7 years ago.
Refresh patch. Conflicts also resolved at https://github.com/x-team/wordpress-develop/pull/1/files
27504.patch (8.4 KB) - added by ocean90 7 years ago.
27504.2.patch (10.1 KB) - added by westonruter 7 years ago.
Replace Options_Transaction with option update capturing with methods merged into class WP_Customize_Widgets. Patches, commits, and conflict resolutions also pushed to https://github.com/x-team/wordpress-develop/pull/1/files
27504.3.patch (42.4 KB) - added by westonruter 7 years ago.
Convert static WP_Customize_Widgets class into instantiated class. Changes also pushed to GitHub: https://github.com/x-team/wordpress-develop/pull/1/files

Download all attachments as: .zip

Change History (18)

#1 @ocean90
7 years ago

  • Keywords needs-refresh added

@westonruter
7 years ago

Refresh patch. Conflicts also resolved at https://github.com/x-team/wordpress-develop/pull/1/files

#2 @westonruter
7 years ago

  • Keywords has-patch added; needs-refresh removed

@ocean90
7 years ago

This ticket was mentioned in IRC in #wordpress-dev by ocean90. View the logs.


7 years ago

@westonruter
7 years ago

Replace Options_Transaction with option update capturing with methods merged into class WP_Customize_Widgets. Patches, commits, and conflict resolutions also pushed to https://github.com/x-team/wordpress-develop/pull/1/files

#5 @westonruter
7 years ago

  • Description modified (diff)

This ticket was mentioned in IRC in #wordpress-dev by westonruter. View the logs.


7 years ago

#7 @westonruter
7 years ago

I'll convert the static-flavoured WP_Customize_Widgets into a properly-instantiated class.

@westonruter
7 years ago

Convert static WP_Customize_Widgets class into instantiated class. Changes also pushed to GitHub: https://github.com/x-team/wordpress-develop/pull/1/files

This ticket was mentioned in IRC in #wordpress-dev by westonruter. View the logs.


7 years ago

#10 @ocean90
7 years ago

In 27815:

Introduce pre_update_option filter.

Filter is available in update_option() and allows to filter any option before its value is (maybe) serialized and updated.

see #27504.
props westonruter.

#11 @ocean90
7 years ago

In 27816:

Widget Customizer: Convert static WP_Customize_Widgets class into instantiated class and merge Options_Transaction into WP_Customize_Widgets.

see #27504.
props westonruter.

This ticket was mentioned in IRC in #wordpress-dev by ocean90. View the logs.


7 years ago

#13 @nacin
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[27816] is great. Really solid. Closing as fixed, great work both.

Note: See TracTickets for help on using tickets.