WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27506 closed defect (bug) (fixed)

Hook Docs (112): wp-includes/class-wp-xmlrpc-server.php

Reported by: kpdesign Owned by: DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: XML-RPC Keywords: has-patch commit
Focuses: docs Cc:
PR Number:

Description

Document all hooks in wp-includes/class-wp-xmlrpc-server.php.

Attachments (6)

27506.diff (29.3 KB) - added by kpdesign 6 years ago.
First pass
27506.2.diff (42.7 KB) - added by DrewAPicture 6 years ago.
2nd pass
27506.3.diff (43.6 KB) - added by kpdesign 6 years ago.
Third pass
27506.4.diff (43.3 KB) - added by DrewAPicture 6 years ago.
Final pass.
27506.5.diff (1.3 KB) - added by DrewAPicture 6 years ago.
props redsweater for the report and the braces
27506.6.diff (1.8 KB) - added by DrewAPicture 6 years ago.

Download all attachments as: .zip

Change History (15)

@kpdesign
6 years ago

First pass

#1 @kpdesign
6 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing

27506.diff is a first pass, and documents the following hooks:

  • xmlrpc_methods
  • xmlrpc_enabled
  • xmlrpc_login_error
  • xmlrpc_blog_options
  • xmlrpc_call
  • xmlrpc_default_post_fields
  • pingback_ping_source_uri
  • 71 duplicate hooks

The following hooks still need to be documented:

Actions (13):

  • xmlrpc_call_success_wp_deletePage
  • xmlrpc_call_success_wp_newCategory
  • xmlrpc_call_success_wp_deleteCategory
  • xmlrpc_call_success_wp_deleteComment
  • xmlrpc_call_success_wp_editComment
  • xmlrpc_call_success_wp_newComment
  • xmlrpc_call_success_blogger_newPost
  • xmlrpc_call_success_blogger_editPost
  • xmlrpc_call_success_blogger_deletePost
  • xmlrpc_call_success_mw_newPost
  • xmlrpc_call_success_mw_editPost
  • xmlrpc_call_success_mw_newMediaObject
  • pingback_post

Filters (20):

  • pre_option_enable_xmlrpc (partial block done)
  • option_enable_xmlrpc (partial block done)
  • xmlrpc_prepare_taxonomy
  • xmlrpc_prepare_term
  • xmlrpc_prepare_post
  • xmlrpc_prepare_post_type
  • xmlrpc_prepare_media_item
  • xmlrpc_prepare_page
  • xmlrpc_prepare_comment
  • xmlrpc_prepare_user
  • xmlrpc_wp_insert_post_data
  • xmlrpc_default_taxonomy_fields
  • xmlrpc_default_user_fields
  • xmlrpc_allow_anonymous_comments
  • xmlrpc_default_posttype_fields
  • xmlrpc_default_revision_fields
  • pre_upload_error
  • xmlrpc_text_filters
  • pre_remote_source
  • xmlrpc_pingback_error

@DrewAPicture
6 years ago

2nd pass

#2 @DrewAPicture
6 years ago

  • Owner changed from DrewAPicture to kpdesign

27506.2.diff covers the remaining hooks. Needs a wording-once-over and recommendation.

@kpdesign
6 years ago

Third pass

#3 @kpdesign
6 years ago

  • Keywords commit added
  • Owner changed from kpdesign to DrewAPicture

27506.3.diff contains changes for language consistency.

This one should be good to go in. Recommend commit.

@DrewAPicture
6 years ago

Final pass.

#4 @DrewAPicture
6 years ago

  • Milestone changed from Awaiting Review to 3.9

27506.4.diff covers it.

#5 @DrewAPicture
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27730:

Inline documentation for hooks in wp-includes/class-wp-xmlrpc-server.php.

Props kpdesign and DrewAPicture.
Fixes #27506.

#6 @DrewAPicture
6 years ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Adding braces were missed for the now-multi-line conditional around the option_enable_xmlrpc hook. See #27746

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


6 years ago

@DrewAPicture
6 years ago

props redsweater for the report and the braces

#8 @DrewAPicture
6 years ago

  • Keywords commit added

27506.5.diff removes the redundant and unnecessary hook docs for the back-compat filters, instead adding a more detail comment.

Also adds braces around the option_enable_xmlrpc conditional, props redsweater in #27746.

@DrewAPicture
6 years ago

#9 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 28065:

XML-RPC: Fix bracing of conditionals around doc blocks.

props redsweater, DrewAPicture.
fixes #27506.

Note: See TracTickets for help on using tickets.