WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#27519 closed defect (bug) (fixed)

PHPDocs: media_handle_upload() returns a WP_Error on failure

Reported by: jdgrimes's profile jdgrimes Owned by: drewapicture's profile DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.0
Component: Media Keywords: has-patch
Focuses: docs Cc:

Description

But it says:

@return int the ID of the attachment

Introduced in [13290].

Attachments (1)

27519.diff​ (712 bytes) - added by jdgrimes 12 years ago.

Download all attachments as: .zip

Change History (5)

@jdgrimes
12 years ago

#1 follow-up: @jdgrimes
12 years ago

  • Keywords has-patch added

I want to ask: Is this kind of patch discouraged? Seems kind of trivial.

#2 in reply to: ↑ 1 @DrewAPicture
12 years ago

Replying to jdgrimes:

I want to ask: Is this kind of patch discouraged? Seems kind of trivial.

Absolutely not. Welcomed and encouraged :)

#3 @DrewAPicture
12 years ago

  • Milestone changed from Awaiting Review to 3.9

#4 @DrewAPicture
12 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 27880:

Clarify PHPDoc return description for media_handle_upload().

Props jdgrimes.
Fixes #27519.

Note: See TracTickets for help on using tickets.