Make WordPress Core

Opened 19 years ago

Closed 19 years ago

Last modified 18 years ago

#2752 closed defect (bug) (wontfix)

link_pages space missing

Reported by: vxnick's profile vxnick Owned by:
Milestone: Priority: low
Severity: trivial Version: 2.0.2
Component: Template Keywords:
Focuses: Cc:

Description

Hi,

In reference to ticket 1477, I have created a new patch based on skippy's existing patch.

I can confirm that this works on my 2.1 Alpha and 2.0.2 installations.

To customise the separator, you need to specify one additional parameter (at the end of the function, to avoid breaking things):

link_pages($before, $after, $next_or_number, $nextpagelink, $previouspagelink, $pagelink, $more_file, $sep);

The new $sep variable defaults to one space character to separate the 'previous' and 'next' text when using <!--nextpage-->.

My apologies if I've missed anything out - this is my first Wordpress patch, and first time using Trac.

Regards,
Nick.

Attachments (2)

template-functions-post.php.diff (953 bytes) - added by vxnick 19 years ago.
Patch to add $sep variable for customising separator.
template-functions-post.php-2.diff (988 bytes) - added by vxnick 19 years ago.
Second patch to hide $sep characters.

Download all attachments as: .zip

Change History (8)

@vxnick
19 years ago

Patch to add $sep variable for customising separator.

#1 @vxnick
19 years ago

  • Milestone set to 2.0.3
  • Priority changed from normal to low

#2 @davidhouse
19 years ago

  • Keywords bg|has-patch added

@vxnick
19 years ago

Second patch to hide $sep characters.

#3 @vxnick
19 years ago

Hi,

I've just attached a newer patch to address the following:

When using the new $sep variable, it would show the $sep value on the last page, after the 'previouspagelink', and on the first page before 'nextpagelink'.

This patch now hides the $sep value if on the first or last page.

Regards,
Nick.

#4 @vxnick
19 years ago

Hi,

It seems this patch stops the Pages from showing in the Sidebar - any ideas why?

Regards,
Nick.

#5 @foolswisdom
19 years ago

  • Keywords bg|has-patch removed
  • Resolution set to wontfix
  • Status changed from new to closed

As above this relates to ticket #1477 which has not been updated in a year.

Removing has-patch tag because last comment suggests it breaks functionality.

Marking WONTFIX for now.

#6 @(none)
18 years ago

  • Milestone 2.0.3 deleted

Milestone 2.0.3 deleted

Note: See TracTickets for help on using tickets.