WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#27522 closed defect (bug) (fixed)

Audit Colors on Theme Install Screen

Reported by: jorbin Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Themes Keywords:
Focuses: ui Cc:

Description

Colors are being used on the theme install screen that aren't in our less so they don't actually get changed to respect the users color theme.

I *think* the only four places that we use color that need to be put into less are:

  • the theme count
  • the feature filter
  • the current filter underline
  • the upload theme button

We should audit this page in general and make sure all colors can be transformed properly and it looks good with different schemes.

Attachments (1)

27522.diff (1.4 KB) - added by ryelle 5 years ago.

Download all attachments as: .zip

Change History (5)

This ticket was mentioned in IRC in #wordpress-dev by jorbin. View the logs.


5 years ago

#2 @helen
5 years ago

I don't think the theme count needs extra attention on it, and the upload theme button seems to get colorized.

@ryelle
5 years ago

#3 @ryelle
5 years ago

I agree that the theme count doesn't need updating. Upload theme also doesn't need anything, the styling there matches the Add New buttons on Plugins, Posts, etc.

In 27522.diff, I've updated the current filter underline (to the menu background color), and the feature filter (to the highlight background color). In the Light scheme, the filter underline is the blue highlight color, otherwise the line was too light.

#4 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27784:

Color scheme support for the new theme installer UI.

props ryelle.
fixes #27522.

Note: See TracTickets for help on using tickets.