WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#27527 closed defect (bug) (fixed)

MCE Image Toolbar doesn't vanish on keyboard image delete

Reported by: mikeschroder Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: needs-patch
Focuses: Cc:

Description

After you've deleted an image from MCE using the keyboard delete/backspace button, the image disappears from view, but the toolbar for edits remains.

To reproduce:

  • Insert image
  • Click on image in Visual editor
  • Press backspace key

Before image delete:
http://screen.getsource.net/03-26-2014-12-31-26.png

After image delete:
http://screen.getsource.net/03-26-2014-12-31-40.png

Attachments (2)

27527-01.patch (2.3 KB) - added by gcorne 5 years ago.
27527-02.patch (3.4 KB) - added by gcorne 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @gcorne
5 years ago

27527-01.patch should fix this.

@gcorne
5 years ago

This ticket was mentioned in IRC in #wordpress-dev by gcorne. View the logs.


5 years ago

#3 @gcorne
5 years ago

27527-02.patch takes what I think is a bit smarter and more performant approach to removing the toolbar on keydown after some discussion with @azaozz.

@gcorne
5 years ago

#4 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27786:

Remove the TinyMCE image toolbar when the image is deleted via the keyboard.

props gcorne.
fixes #27527.

Note: See TracTickets for help on using tickets.