Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#27531 closed defect (bug) (fixed)

Hook Docs (9): wp-includes/class-wp-customize-widgets.php

Reported by: ocean90's profile ocean90 Owned by: drewapicture's profile DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Customize Keywords: has-patch commit
Focuses: docs Cc:


Old hooks:

  • load-widgets.php (twice)
  • widgets.php (twice)
  • sidebar_admin_setup (twice)

New hooks:

  • customizer_widgets_section_args
  • is_wide_widget_in_customizer
  • widget_customizer_setting_args

Attachments (1)

27531.diff (1.2 KB) - added by DrewAPicture 10 years ago.

Download all attachments as: .zip

Change History (10)

#1 @ocean90
10 years ago

To reduce the hooks by 3 we can also call customize_controls_init() (we should rename the function too) in wp_ajax_update_widget().

#2 @jeremyfelt
10 years ago

  • Milestone changed from Awaiting Review to 3.9

#3 @ocean90
10 years ago

sidebar_admin_setup is documented in /wp-admin/includes/ajax-actions.php and /wp-admin/widgets.php. One should be marked as a duplicate, probably in ajax-actions.php.

#4 @DrewAPicture
10 years ago

In 27823:

The sidebar_admin_setup hook should only be documented once in wp-admin/widgets.php. All others are duplicates.

See #25374, #25501, #27531.

#5 @DrewAPicture
10 years ago

  • Keywords needs-patch removed
  • Milestone 3.9 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Let's just handle these in #27534, keep everything together.

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.

10 years ago

10 years ago

#7 @DrewAPicture
10 years ago

  • Keywords has-patch commit added
  • Milestone set to 3.9
  • Resolution duplicate deleted
  • Status changed from closed to reopened

27531.diff accounts for hook docs missed in #27534.

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.

10 years ago

#9 @DrewAPicture
10 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from reopened to closed

In 28117:

Inline documentation for hooks in wp-includes/class-wp-customize-widgets.php

Fixes #27531.

Note: See TracTickets for help on using tickets.