Display for Unattached Media showing all images (instead of just unattached)

[Ipstenu]

Reproduced this on 3 installs, does not happen on 3.8.1

Go into Media Library, click on 'Unattached'

The count (in my case 3) is correct. The images are not.

All images:

Unattached images:

[SergeyBiryukov]

Confirmed.

[samuelsidler]

I can reproduce this as well. Definite regression. Blocker.

[SergeyBiryukov]

Introduced in [27373]: trunk/src/wp-admin/includes/post.php?rev=27690#L995​.

$q['post_parent'] = 0 doesn't work as expected in WP::parse_request(), because it's not declared as a public or a private query var. It ends up in $extra_query_vars and is not passed to WP_Query::get_posts().

27532.patch​ fixes that, but we can probably just revert that part of [27373].

[SergeyBiryukov]

The wp() call comes from [2646], [3564], and [6910].

We could probably use query_posts() directly instead: 27532.2.patch​.

Still, not including post_parent in $private_query_vars seems like an omission.

[nacin]

Switching to query_posts() would break a ton, and it'd be insecure. wp() keeps things safe for us.

Adding post_parent as a private query var is fine.

[nacin]

In 27782:

Add post_parent to the private query vars list. Fixes detached media queries.

props SergeyBiryukov.
fixes #27532.