Unobtrusive JS for "Quick Edit" button at "Comments" page and others

[aubreypwd]

In #24741 I fixed the issue where onclick= was being used to call a function, but it wasn't the ideal fix. We want to fix that instance, and other applicable instances in core (if any), to be unobtrusive if possible.

[aubreypwd]

Using unobtrusive JS on comment "Reply," and "Quick Edit."

[aubreypwd]

I've added a patch to solve #24741 using un-obtrusive JS.

[aubreypwd]

@SergeyBiryukov I saw you slated another ticket of mine for 4.0, can we get this one in? I think it's better than what's there.

[wonderboymusic]

I like this but it should use event delegation:

$( 'body' ).on( 'click', '.class-name, .other-class', function (e) {
    e.preventDefault();

    var element = $( e.currentTarget );

   // whatever 
}  );

[aubreypwd]

Update per @wonderboymusic suggestion with delegation.

[aubreypwd]

Updates to tabs.

[wonderboymusic]

In 28810:

Use unobtrusive JS for Comment list table row actions.

Props aubreypwd.
Fixes #27533.

[nacin]

[28810] does a few particularly weird things:

• It lets things bubble up to the body, rather than using a more direct parent like #the-comment-list or table.comments or whatever.
• It uses a lot of unnecessary cascading: .comment .row-actions .quickedit .edit-comment-inline. Something like .edit-comment-inline should be sufficient.
• Why does it use event.currentTarget rather than this?
• commentReply has to be defined; it's in this JS file. Those checks were only there because it was obtrusive JS and it could have been triggered before this file was loaded.

[helen]

27533.4.diff​ addresses the above points, all of which I agree with. In particular, I would love to know why there's been a proliferation of event.currentTarget instead of this recently, and if there are any specific places that actually need the differentiation.

[helen]

27533.5.diff​ consolidates the callback.

[helen]

In 29662:

Comments: Simplify JS for inline edit and reply.

fixes #27533.

[aubreypwd]

My original patch used this, but I took @wonderboymusic's advice on a second patch; that was all.