Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#27535 closed defect (bug) (fixed)

Video playlist uses the same interface for embed settings as Audio playlist

Reported by: ericlewis's profile ericlewis Owned by: wonderboymusic's profile wonderboymusic
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: needs-patch
Focuses: ui Cc:

Description

Video playlists and audio playlists share the same embed settings.

"Random Order," "Show Tracklist," "Show Track Numbers," "Show Artist Name in Tracklist," and "Show Images."

"Show Artist Name in Tracklist" is irrelevant for video playlists (as far as I understand videos don't have artists associated with them)

The term "tracks" works fine for an audio playlist, but referring to videos as tracks is strange.

Attachments (1)

Screenshot 2014-03-26 17.50.42.png (81.5 KB) - added by ericlewis 10 years ago.

Download all attachments as: .zip

Change History (6)

#1 @wonderboymusic
10 years ago

In 27751:

Don't display the "Show Artist Name in Tracklist" input in settings for Video Playlists.

See #27535.

#2 @wonderboymusic
10 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.9

Any recommendations for verbiage?

#3 @wonderboymusic
10 years ago

In 27793:

Remove tracknumbers from the UI, can still be overridden as a playlist shortcode attribute.

See #27535.

#4 @wonderboymusic
10 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 27796:

When labeling Show Tracklist for playlist settings, use Show Video List when the playlist is video.

Fixes #27535.

#5 @wonderboymusic
10 years ago

In 27812:

When creating a new playlist, we don't know from the model what "type" it is right away (there is no longer a video-playlist shortcode) - we need to check the controller's library's prop for type when deciding what settings to display in the modal.

See #27535.

Note: See TracTickets for help on using tickets.