Opened 11 years ago
Closed 11 years ago
#27546 closed defect (bug) (fixed)
Issues with Tiny MCE Views in IE8
Reported by: | ocean90 | Owned by: | gcorne |
---|---|---|---|
Milestone: | 3.9 | Priority: | high |
Severity: | major | Version: | 3.9 |
Component: | TinyMCE | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
In IE8 after selecting a view like gallery, audio or playlist, you can see the shortcode. See attached screenshots.
Attachments (9)
Change History (22)
#2
@
11 years ago
The primary issue here is being caused by ie7_compat
being set to true
, which is the default in TinyMCE. This causes <meta http-equiv="X-UA-Compatible" content="IE=7" />
to be written out in the <head>
of the iframe. It doesn't fix all the issues, but it is at least usable in terms of working with views and editing images.
This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.
11 years ago
#5
@
11 years ago
Plan per IRC:
- Prepare fallbacks in the form of image placeholders and also images for edit/delete icons
- speak to Spocke (TinyMCE) what may break if we have IE8 without the IE7 compat mode (we can either keep IE7 compat mode on for IE7, or just turn off TinyMCE entirely for IE7)
- Commit to one or the other by Wednesday
#7
@
11 years ago
27546-01.patch adds the following ie8/ie7 tinymce fixes:
- Adds fallback background images for dashicons
- Use inline instead of inline-block
- Add a hack to hide the clipboard while still allowing the contents to be selected
- Work around lack of border-box in gallery styles
We still need to try and find a way to keep the ugly control selection bars from appearing where possible, and it seems that the padding elements are not being stripped in all cases.
#8
@
11 years ago
images.zip includes new versions of the dashicon fallback images that @melchoyce made for me. They are a bit sharper and bolder than the original versions that I posted.
27546-02.patch fixes an issue where when a view is selected, it was super hard to place the caret in content that precedes the view in IE8. The patch also makes the ugly gray bars appear less frequently by always deselecting and then reselecting the view in IE. The bars will appear on mousedown and then disappear on mouseup.
#10
@
11 years ago
27546-03.patch fixes a regression introduced in [28062] where the type of event used to deselect a wpview was always mouseup
, which was not intended. For Chrome, it needs to be mousedown
in order for the caret to be placed at the proper position.
In audio.ie8.png the edit toolbar also overlaps the play icon.