WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27562 closed defect (bug) (fixed)

Playlist shortcode text is unreadable when using the default light color scheme on themes that have light text.

Reported by: kwight Owned by: helen
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords:
Focuses: ui Cc:

Description

The default light color scheme for the playlist shortcode inherits its text color from the body element. If a theme has light text over a dark background, the shortcode's text will also be light, but over its own light background.


The attached patch specifies text colors for the light color scheme, making theme color choices irrelevant.

Attachments (3)

playlist-before.png (58.3 KB) - added by kwight 6 years ago.
playlist-light-colors.diff (762 bytes) - added by kwight 6 years ago.
playlist-after.png (106.5 KB) - added by kwight 6 years ago.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.9

@kwight
6 years ago

#2 @helen
6 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 27805:

Set baseline colors for the light playlist skin. props kwight. fixes #27562.

#3 @nacin
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for further review; wonderboymusic and I discussed ditching colors nearly entirely and letting the theme do it all. I might have misunderstood, but want to make sure this gets reviewed.

#4 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This appears to be good. Someone reopen if anything else blows up. Similar to [27865], we need to set the basics.

Note: See TracTickets for help on using tickets.