Widget Customizer: Inconsistent use of Delete / Remove

[jeremyfelt]

When using the standard widget administration in wp-admin/widgets.php, each current widget in a sidebar has a 'Delete' and a 'Close' link. If a new widget is added to a sidebar, the same Delete and Close links are used.

When using the widget controls in the customizer, existing widgets appear with Remove and Close links. When a new widget is added through the customizer, it initially appears with a Delete and Close link.

I haven't found any conversation around this in a previous ticket. Sticking with Delete and Close would be a more consistent experience. Patch attached.

[westonruter]

It is all intentional, actually. When a widget is added to a widget area but is not yet saved, then the "Delete" link is present. When the widget gets saved for the first time, it will change to "Remove"; at this point, instead of the widget instance being lost forever, clicking Remove places it in the Inactive Widgets sidebar, which then becomes a sort of widget trash can. If you hover over the link, you'll see a tooltip:

Trash widget by moving it to the inactive widgets sidebar.

See original discussion on IRC, where we dive into the rationale for this: ​https://irclogs.wordpress.org/chanlog.php?channel=wordpress-ui&day=2013-10-14&sort=asc#m128535

See also these GitHub issues:
​https://github.com/x-team/wp-widget-customizer/issues/22
​https://github.com/x-team/wp-widget-customizer/issues/49

[ocean90]

I agree with westonruter. Remove is for moving the widget to the Inactive Widgets area.

[nacin]

Fine by me, I wasn't paying close attention.

[ocean90]

#33951 was marked as a duplicate.

[westonruter]

#39426 was marked as a duplicate.

[afercia]

I get it's intentional, however it's inconsistent with the Widgets screen. See also #28888

[westonruter]

#41087 was marked as a duplicate.