Shortcodes and nbsp

[miqrogroove]

Continuing from #22692 and as a requirement for #26842, we need to make sure things like  [gallery ids="37,15,11"]  are treated the same as if they are surrounded by whitespace.

The patch for shortcode_unautop() is ready, and there could be other changes needed.

[wonderboymusic]

In 28708:

Add a function: wp_spaces_regexp(). It is not used yet.

This function is required by a bunch of patches by miqrogroove. Needs filter docs.

Props miqrogroove.
See #27588.

[SergeyBiryukov]

What would be a use case for the wp_spaces_regexp filter?

[wonderboymusic]

Good question - if there isn't a good one, we can delete it.

[DrewAPicture]

Seems like the use case would be to change the regex, unless I'm missing something, currently it includes "spaces include new lines, tabs, nbsp entities, and the UTF-8 nbsp".

Happy to write the hook docs if ya'll come to a consensus on whether to keep the filter.

[SergeyBiryukov]

Replying to DrewAPicture:

Seems like the use case would be to change the regex, unless I'm missing something, currently it includes "spaces include new lines, tabs, nbsp entities, and the UTF-8 nbsp".

Yeah, I mean, is there a need for this regex to be filterable?

[miqrogroove]

Replying to SergeyBiryukov:

What would be a use case for the wp_spaces_regexp filter?

Primarily for anyone not using UTF-8. NBSP has alternative encodings.

[miqrogroove]

Refreshed

[miqrogroove]

Filter docs added.

[miqrogroove]

Replying to wonderboymusic:

In 28708:

Add a function: wp_spaces_regexp(). It is not used yet.

This function is required by a bunch of patches by miqrogroove. Needs filter docs.

Props miqrogroove.
See #27588.

Thank you. Patch refreshed.

[wonderboymusic]

In 28716:

Ensure that shortcode_unautop() treats   like whitespace.
shortcode_unautop() and wptexturize() now use wp_spaces_regexp() instead of raw regex.

Adds unit tests.

Props miqrogroove.
See #27588.

[wonderboymusic]

Please review/alter/whatever the inline docs. If they're good, mark as fixed. Otherwise, commit whatever then mark as fixes.

[DrewAPicture]

In 28724:

Improve inline documentation for the wp_spaces_regexp filter.

Fixes #27588.