Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#27597 closed defect (bug) (fixed)

Need Space in New Header Image Upload Feature in Theme Customizer

Reported by: davidakennedy's profile davidakennedy Owned by: nacin's profile nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

On the /wp-admin/customize.php/ screen the copy for the header image upload feature needs a space after the first sentence. It reads:

Personalize your site with your own header image.While you can crop images to your liking after clicking Add new, your theme recommends a header size of 1260 × 240 pixels.

Should be: Personalize your site with your own header image. While you can crop images to your liking after clicking Add new, your theme recommends a header size of 1260 × 240 pixels.

Attachments (3)

27597.diff (122 bytes) - added by rachelbaker 11 years ago.
Added space in Customizer header section help text.
27597.patch (1.6 KB) - added by rachelbaker 11 years ago.
Added space in Customizer header section help text. Corrected patch file.
27597.2.patch (804 bytes) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @ocean90
11 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.9

Correct, see ticket:21785:39.

@rachelbaker
11 years ago

Added space in Customizer header section help text.

@rachelbaker
11 years ago

Added space in Customizer header section help text. Corrected patch file.

#2 @rachelbaker
11 years ago

  • Keywords has-patch added; needs-patch removed

Added patch with space added in Customizer Header section text.

#3 follow-up: @SergeyBiryukov
11 years ago

We should keep the space out of translatable strings (even though they are not translatable right now, pending additional study), otherwise it can be missed in translation. See 27597.2.patch.

#4 in reply to: ↑ 3 @rachelbaker
11 years ago

Replying to SergeyBiryukov:

We should keep the space out of translatable strings (even though they are not translatable right now, pending additional study), otherwise it can be missed in translation. See 27597.2.patch.

Gotcha, that makes sense. Thank you for the feedback and patch refresh.

#5 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27945:

Add missing space between strings.

props rachelbaker.
fixes #27597.

#6 @nacin
11 years ago

One of the reasons why these strings got split was because I wanted to axe "Personalize your site with your own header image" as it was an introduction we don't really need buried in a single section in the customizer. I'll handle that in the main ticket, #21785.

Note: See TracTickets for help on using tickets.