Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#27599 closed defect (bug) (invalid)

Twenty Fourteen: featured content in customizer preview

Reported by: afercia's profile afercia Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8.1
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

in the customizer preview, when you input a new tag for featured content, suggest.js shows you a list of matching tags: when you select one of those nothing changes in the preview.
Proposed patch just triggers a jQuery "change" event on the input field, using the suggest.js 'onSelect' callback.

Attachments (1)

27599.patch (744 bytes) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (13)

@afercia
11 years ago

#1 @afercia
11 years ago

  • Keywords has-patch needs-testing added

#2 @rachelbaker
11 years ago

Tested the patch and it works well.

#3 @lancewillett
11 years ago

  • Keywords reporter-feedback added; needs-testing removed

I'm not sure I understand this report. Right now when you pick a new tag in Customizer, the entire preview in the Customizer iframe refreshes to show the new content. That's by design and how the theme has worked since it launched ...

when you select one of those nothing changes in the preview.

Can you explain this more? And give us more debugging info please: browser, OS, device, URL, WP and theme version, active plugins, language settings if any, and any other steps to repeat the issue exactly.

I don't think this needs fixing.

#4 @afercia
11 years ago

say you have a tag "template"
start typing in the input field, stop typing at "temp" and wait suggest.js to kick in. Then click on the suggested "template" tag.
For me, nothing changes in the preview iframe because no "change" event is triggered.
Inspecting Chrome console, I see a GET to admin-ajax.php?action=ajax-tag-search&tax=post_tag&q=mark but I don't see any XHR POST, no refresh at all.

Maybe you see something changing in the preview because if you have sticky posts, it will fallback to sticky posts but actually it's ignoring the tag you just entered.
Be sure you don't have any of your posts marked as "sticky" and it will be easier to spot.

Instead, when you ignore suggest.js and you complete manually typing "template", all works fine.

Tested on WP 3.8.1 and trunk, Twenty Fourteen 1.0. No plugins. I always try to test software in original language even if English is not my main language (I guess you noticed that :)). Environment doesn't matter, there's just no POST.

#5 @lancewillett
11 years ago

Working as expected for me in Firefox, Chrome, and Safari on Mac OSX Mavericks in both 3.8.1 and trunk and latest Twenty Fourteen with no plugins.

Here's a screencast: https://cloudup.com/cJxOVPRLTwK

#6 @afercia
11 years ago

ok maybe I got why.
I had define('SCRIPT_DEBUG', false) and maybe you have set it to true.
So I was getting the minified version.
Just spotted a difference between suggest.js and suggest.min.js :( so bad.
In suggest.js (not minified) around line 253 I see:

$input.trigger('change');

and that's the 'change' event that triggers the refresh, but in the minified version there's no change event triggered.
This difference is visible also in trunk:
http://develop.svn.wordpress.org/trunk/src/wp-includes/js/jquery/suggest.js
and
http://develop.svn.wordpress.org/trunk/src/wp-includes/js/jquery/suggest.min.js
just do a text search for "change".
So sorry, seems it was not Twenty Fourteen to blame :) and I was basically applying the right fix in the wrong place :)
Can you please confirm you're testing with the not-minified version? If you can replicate this issue testing with the minified version, maybe we should update to the right component.

Well I would also add a

$input.focus();

just before the 'change'.

Thx and sooorry
Andrea

#7 @afercia
11 years ago

btw in your screencast, you write the complete word, say "alignment" and then click on the suggested tag "alignment". That's not the point :)

  • just start typing "alig" then stop.
  • *wait*
  • suggest.js will kick in
  • while in the input field the word is still incomplete ("alig") click on the suggested "alignment"

#8 @afercia
11 years ago

  • Keywords has-patch reporter-feedback removed
  • Resolution set to invalid
  • Status changed from new to closed

closing, not a Twenty Fourteen bug see #27621

#9 @lancewillett
11 years ago

  • Milestone Awaiting Review deleted

Can you please confirm you're testing with the not-minified version?

Yes, I was testing with the SCRIPT_DEBUG flag set to true.

#10 @ocean90
11 years ago

In 27911:

Update suggest.min.js for [26333].

see #26110, #27599.
fixes #27621.

#11 @lancewillett
11 years ago

Nice report afercia. :)

Glad to see you active in Trac and making improvements to WordPress.

#12 @afercia
11 years ago

thx lance :)
sorry for wasting your time blaming Twenty Fourteen

Note: See TracTickets for help on using tickets.