#2761 closed defect (bug) (fixed)
AYS Dialog adds slashes to quotes
Reported by: | markjaquith | Owned by: | markjaquith |
---|---|---|---|
Milestone: | Priority: | high | |
Severity: | major | Version: | 2.0.2 |
Component: | Administration | Keywords: | has-patch 2nd-opinion |
Focuses: | Cc: |
Description
Post forms that go through the AYS dialog get an extra round of slashes. For instance, editing a comment turns
I'm going home.
Into:
I\'m going home
This is for version 2.0.3
Attachments (2)
Change History (12)
#1
@
18 years ago
- Keywords has-patch 2nd-opinion added
- Owner changed from anonymous to markjaquith
- Status changed from new to assigned
Patch changes the hidden inputs to hidden textareas. That way, we don't need to escape slashes.
#2
@
18 years ago
The AYS should be designed to work in all manner of strange browsers (mobile, etc.). Can we depend on everything to deal with the CSS?
I don't understand why can't we just stripslashes the hidden field value.
This isn't a problem in trunk, but I don't see the difference. Do you?
#7
@
18 years ago
Just tested Ryan's patch, and it works.
I tested by editing /wp-admin/post.php and purposely mismatching the nonce keys.
And mdawaffe, yeah, you're right. I was really tired when I wrote that. Single quotes are already converted to HTML entities, so there's no problem sticking it in a hidden input.
#8
@
18 years ago
How do us plebs apply this patch? Could someone provide an updated version of the file for 2.0.3?
Patch for 2.0.3 (branches/2.0)