Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#27614 closed defect (bug) (fixed)

Removing lastupdated column via filter in the MS Sites List Table can cause a notice

Reported by: jeremyfelt's profile jeremyfelt Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.1
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:

Description

In WP_MS_Sites_List_Table->display_rows(), the registered column assumes that the $date set by the lastupdated column is available to it. If the lastupdated column is filtered out, $date is not available and a notice is shown.

Setting this date format is not expensive at all. the attached patch moves it to the top of display_rows() so that it is available throughout.

Attachments (1)

27614.diff (978 bytes) - added by jeremyfelt 10 years ago.

Download all attachments as: .zip

Change History (3)

@jeremyfelt
10 years ago

#1 @jeremyfelt
10 years ago

  • Milestone changed from Future Release to 4.0

#2 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 28898:

Set date format before going into the loop to avoid a PHP notice if 'lastupdated' column is filtered out.

props jeremyfelt.
fixes #27614.

Note: See TracTickets for help on using tickets.